Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate chunksize from dask_cudf.read_csv #12394

Merged
merged 15 commits into from
Jan 13, 2023
Merged

Deprecate chunksize from dask_cudf.read_csv #12394

merged 15 commits into from
Jan 13, 2023

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Dec 15, 2022 •
edited
Loading

Description

Deprecates chunksize in favor of blocksize to be consistent with dask.dataframe.read_csv.

Closes #11847

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 15, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 15, 2022
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 15, 2022
@rjzamora rjzamora marked this pull request as ready for review December 15, 2022 16:59
@rjzamora rjzamora requested a review from a team as a code owner December 15, 2022 16:59
@codecov
Copy link

codecov bot commented Dec 15, 2022 •
edited
Loading

Codecov Report

Base: 85.67% // Head: 85.67% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a540419) compared to base (126829c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02   #12394      +/-   ##
================================================
- Coverage         85.67%   85.67%   -0.01%     
================================================
  Files               155      155              
  Lines             24812    24818       +6     
================================================
+ Hits              21258    21263       +5     
- Misses             3554     3555       +1
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/backends.py 85.32% <100.00%> (+0.15%) ⬆️
python/dask_cudf/dask_cudf/io/csv.py 96.34% <100.00%> (-1.00%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.46% <0.00%> (-0.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jan 5, 2023
wence-
wence- approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rapids-bot
Copy link

rapids-bot bot commented Jan 13, 2023

@rjzamora, the @gpucibot merge command has been replaced with /merge.

Please re-comment this PR with /merge and use this new command in the future.

@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit ec7f8c6 into rapidsai:branch-23.02 Jan 13, 2023
@rjzamora rjzamora deleted the deprecate-chunksize branch January 13, 2023 17:07
@mroeschke mroeschke mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dask_cudf read_csv does not support dask.dataframe's blocksize argument (vs. chunksize)
3 participants
@rjzamora @wence- @galipremsagar